Skip to content

Commit

Permalink
Tolerate 502 errors from github on issue comments (#54)
Browse files Browse the repository at this point in the history
Co-authored-by: Eric Boucher <[email protected]>
  • Loading branch information
laurentS and ericboucher authored Dec 22, 2021
1 parent e2f1f51 commit 2ae06d4
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tap_github/repository_streams.py
Original file line number Diff line number Diff line change
Expand Up @@ -550,6 +550,9 @@ class IssueCommentsStream(GitHubStream):
parent_stream_type = RepositoryStream
state_partitioning_keys = ["repo", "org"]
ignore_parent_replication_key = False
# FIXME: this allows the tap to continue on server-side timeouts but means
# we have gaps in our data
tolerated_http_errors = [502]

def get_records(self, context: Optional[dict] = None) -> Iterable[Dict[str, Any]]:
"""Return a generator of row-type dictionary objects.
Expand Down

0 comments on commit 2ae06d4

Please sign in to comment.