Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of get_next_page_token in the tap #215

Closed
laurentS opened this issue Jun 9, 2023 · 2 comments
Closed

Replace use of get_next_page_token in the tap #215

laurentS opened this issue Jun 9, 2023 · 2 comments
Labels
skills:Python

Comments

@laurentS
Copy link
Contributor

laurentS commented Jun 9, 2023

Throughout CI runs, we are now getting this warning:

/home/runner/work/tap-github/tap-github/.venv/lib/python3.11/site-packages/singer_sdk/streams/rest.py:487:
   DeprecationWarning: `RESTStream.get_next_page_token` is deprecated and will not be used
   in a future version of the Meltano Singer SDK. Override `RESTStream.get_new_paginator` instead.

We should update the code to use the new method.
@JohannesRudolph
Copy link

seems like a duplicate of #171

@laurentS
Copy link
Contributor Author

Oops. Indeed, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
skills:Python
Projects
MeltanoLabs Overview
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JohannesRudolph @laurentS