Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow streams incorrectly claim to support incremental loading #216

Closed
JohannesRudolph opened this issue Jun 9, 2023 · 3 comments · Fixed by #325
Closed

Workflow streams incorrectly claim to support incremental loading #216

JohannesRudolph opened this issue Jun 9, 2023 · 3 comments · Fixed by #325

Comments

@JohannesRudolph
Copy link

So most GitHubRestStream descendants in the tap support incremental loading using a combination of updated_at replication key and GH APIs since parameter, e.g. repository issues
https://docs.github.com/en/rest/issues/issues?apiVersion=2022-11-28#list-repository-issues

None of GitHub's APIs used for workflow, workflow_runs and workflow_run_jobs streams however supports those parameters, see e.g. https://docs.github.com/en/rest/actions/workflows?apiVersion=2022-11-28#list-repository-workflows

Nonetheless, the tap sets replication keys accordingly and creates huge state files (esp. for workflow_run_jobs) where every run_id seems to get its own partition.

In my pipelines this results in append only behavior where instead I should probably do full loads instead.

A possible solution here might be to use the use_fake_since_parameter but I haven't checked this yet and would appreciate if one of the experts of this tap could offer an insight

@ranpa
Copy link

ranpa commented Oct 9, 2024

Hey @JohannesRudolph! How are you?

Were you able to sort this out? My team has just faced this issue this week and we were wondering whether we would need to try fixing it ourselves or try another solution.

I would really appreciate any update on this.

Thank you!

@JohannesRudolph
Copy link
Author

JohannesRudolph commented Oct 9, 2024 via email

@edgarrmondragon
Copy link
Member

PR to address this: #325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
3 participants