From 00bcd465261c741e57280bbea9913f920cd23861 Mon Sep 17 00:00:00 2001 From: SuchUsernameMuchWow <121036461+SuchUsernameMuchWow@users.noreply.github.com> Date: Thu, 17 Oct 2024 21:10:37 +0200 Subject: [PATCH] fix: increase dimensions limit to 9 (#260) Currently this tap only allows a maximum of 7 dimensions per report, even though the actual limit is 9. [Docs](https://developers.google.com/analytics/devguides/reporting/data/v1/rest/v1beta/Dimension): > Requests are allowed up to 9 dimensions. --- tap_google_analytics/tap.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tap_google_analytics/tap.py b/tap_google_analytics/tap.py index e873b7a..4e3e2cc 100644 --- a/tap_google_analytics/tap.py +++ b/tap_google_analytics/tap.py @@ -217,9 +217,9 @@ def _validate_report_def(self, reports_definition): ) sys.exit(1) - if len(dimensions) > 7: # noqa: PLR2004 + if len(dimensions) > 9: # noqa: PLR2004 self.logger.critical( - "'%s' has too many dimensions defined. GA reports can have maximum 7 " + "'%s' has too many dimensions defined. GA reports can have maximum 9 " "dimensions.", name, )