Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whenmodified does not update when account name is changed #24

Open
pnadolny13 opened this issue Dec 18, 2024 · 2 comments
Open

whenmodified does not update when account name is changed #24

pnadolny13 opened this issue Dec 18, 2024 · 2 comments

Comments

@pnadolny13
Copy link
Contributor

The general ledger details stream is incrementally synced using the whenmodified field but that field does not get updated when some reference data is updated. For example the general ledger accounts table has updates to the account names and the modified date is updated there but in the GL details table that account name is not updated incrementally because the modified date is not updated. Doing a full table sync returns the updated account names so they do get updated but they arent updating the modified date.

@pnadolny13
Copy link
Contributor Author

cc @edgarrmondragon

One idea is to handle this in the transformation layer which is outside the control of this tap. We can always join in the source of truth table (general ledger accounts in this case) when accessing its metadata. If this is the solution we may want to consider removing metadata fields like this from the general ledger stream so that they arent relied on if they may go stale over time.

@edgarrmondragon
Copy link
Member

If this is the solution we may want to consider removing metadata fields like this from the general ledger stream so that they arent relied on if they may go stale over time.

That sounds reasonable to me.

I'm trying to think of how could enable something like via a new feature this from upstream in the SDK, but it's probably too complicated and not as common.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants