Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database in config required #10

Open
jlloyd-widen opened this issue Aug 16, 2023 · 1 comment
Open

Database in config required #10

jlloyd-widen opened this issue Aug 16, 2023 · 1 comment

Comments

@jlloyd-widen
Copy link

Running the tap for the first time I got this error:

File "/opt/dagster/app/.meltano/extractors/tap-mysql--collective/venv/lib/python3.8/site-packages/tap_mysql/tap.py", line 170, in get_sqlalchemy_url
    database=config["database"],

KeyError: 'database'

The docs indicate that this is not a required parameter, indeed, it would be a regression compared to previous versions of this tap.

@visch
Copy link
Member

visch commented Aug 16, 2023

Yeah we can definitely remove that. So you know right now the database doesn't even limit you to just that database anyway so it's pretty pointless right now. Maybe we should use the database parameters instead of filter db option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants