-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream name splits feature should be togglable #58
Comments
Dug into the issue and the core issue with that PR is a few layered issues
To fix 2. above we're going to probably want to call SQLAlchemy directly for our table inserts and creations. We could also start doing that all ourselves manually instead of using SQLAlchemy which would also work, but we'd have to replace everywhere that we use SQLAlchemy to take care of things for us. We should probably just fix the places we're writing SQL Directly in the target instead. Edit: A much easier fix could be to just make a function for the "correct" quoted table reference name. That way I don't have to fix all of this here. |
re https://meltano.slack.com/archives/C01TCRBBJD7/p1673366790519269?thread_ts=1671688563.297449&cid=C01TCRBBJD7
We should be able to turn off the stream name splits feature for folks that don't want it. Also we should output when we detect a stream split so that folks that have no idea the feature exists can at least have some indicator that the behavior may not be what they want (Like in the case from that slack thread where the stream in this case from dynamo has a dash in the name, but the user didn't want the dash's to represent different schemas/table names. )
The text was updated successfully, but these errors were encountered: