Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove replicated initial condition from states list in test configurations #43

Closed
twsearle opened this issue Aug 16, 2023 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@twsearle
Copy link
Collaborator

twsearle commented Aug 16, 2023

Description

We discovered that the initial condition and the first entry in the states list are both passed to oops::GetValues::apply. This means that time interpolation is attempted between two identical states. This does no damage in this case, however it is confusing and possibly incurs a small performance hit.

Provided we receive confirmation that the initial state should not be replicated in the first entry in the states list (in JCSDA-internal/oops#2243), we will need to update the orca-jedi tests and the sith yaml configurations to account for this.

There will also be an impact on sith. I have had a go at a change here:
http://fcm9/projects/utils/browser/ocean_obs_processing_apps/branches/dev/tsearle/r34276_no_initial_condition_in_states
But I will likely need to make a ticket to cover this issue in that repo.

Acceptance Criteria (Definition of Done)

ctests and sith still pass

Dependencies

JCSDA-internal/oops#2243

@twsearle twsearle added the bug Something isn't working label Aug 16, 2023
@twsearle twsearle self-assigned this Aug 16, 2023
@tom-j-h
Copy link
Contributor

tom-j-h commented Mar 27, 2024

This can be closed, right @twsearle? #73. My bad if so!

@twsearle
Copy link
Collaborator Author

Ahh yes sorry! I guess the issue and the PR didn't link properly closing it now. Let me know if you need anything else though.

@tom-j-h
Copy link
Contributor

tom-j-h commented Mar 27, 2024

Thank you, all good for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants