Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-component default configs #1196

Open
reidsunderland opened this issue Aug 28, 2024 · 0 comments
Open

Per-component default configs #1196

reidsunderland opened this issue Aug 28, 2024 · 0 comments
Labels
enhancement New feature or request Sugar nice to have features... not super important. wishlist would be nice, not pressing for any particular client.

Comments

@reidsunderland
Copy link
Member

We've discussed this before, but I couldn't find an issue for it. It's possible that an issue already exists.

There are cases where it would be useful to have default configs on a per-component basis. This is something that we had in v2, but was rarely (or never?) used. I think part of the reason it was rarely used was because v2 had different per-component defaults in the code. In sr3, we've mostly done away with that because it was confusing and now have the same defaults across the board.

Because we now (in sr3) have the same defaults for all components in the code, now the per-component defaults might actually be useful.

In v2, you'd put your per-component defaults in ~/.config/sarra/component.conf, like ~/.config/sarra/winnow.conf:

When a component is started up, a series of configuration files are read in the following sequence:

default.conf
admin.conf
.conf (subscribe.conf, audit.conf, etc...)
/.conf

https://github.com/MetPX/sarracenia/blob/v2_dev/doc/sr_subscribe.1.rst#option-order

But we discussed that putting them in the directory might make more sense, like ~/.config/sr3/winnow/default.conf (or maybe default.inc would be better? or easier to implement?). This (putting a default file in a subdirectory) would also be somewhat more in line with eliminating components. #494

@reidsunderland reidsunderland added enhancement New feature or request wishlist would be nice, not pressing for any particular client. Sugar nice to have features... not super important. labels Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Sugar nice to have features... not super important. wishlist would be nice, not pressing for any particular client.
Projects
None yet
Development

No branches or pull requests

1 participant