Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(snap-keyring-bridge): sanitize redirect URL #70

Merged
merged 3 commits into from
Oct 11, 2024
Merged

feat(snap-keyring-bridge): sanitize redirect URL #70

merged 3 commits into from
Oct 11, 2024

Conversation

ccharly
Copy link
Collaborator

@ccharly ccharly commented Oct 11, 2024

Sanitize redirect URL when using the Snap keyring bridge.

@ccharly ccharly force-pushed the feat/snap-bridge-url-sanitizing branch from e73423a to 3ed870e Compare October 11, 2024 09:53
@ccharly
Copy link
Collaborator Author

ccharly commented Oct 11, 2024

@metamaskbot publish-preview

1 similar comment
@ccharly
Copy link
Collaborator Author

ccharly commented Oct 11, 2024

@metamaskbot publish-preview

@ccharly ccharly force-pushed the feat/snap-bridge-url-sanitizing branch from 619dd49 to 84e4c35 Compare October 11, 2024 10:10
@ccharly
Copy link
Collaborator Author

ccharly commented Oct 11, 2024

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/keyring-api": "8.1.3-84e4c35",
  "@metamask-previews/eth-hd-keyring": "7.0.4-84e4c35",
  "@metamask-previews/eth-ledger-bridge-keyring": "5.0.1-84e4c35",
  "@metamask-previews/eth-simple-keyring": "6.0.5-84e4c35",
  "@metamask-previews/eth-trezor-keyring": "4.0.0-84e4c35",
  "@metamask-previews/eth-snap-keyring": "4.3.6-84e4c35"
}

@ccharly ccharly force-pushed the feat/snap-bridge-url-sanitizing branch from 8dbfa6d to 850ba42 Compare October 11, 2024 14:22
@ccharly
Copy link
Collaborator Author

ccharly commented Oct 11, 2024

@metamaskbot publish-preview

@ccharly ccharly force-pushed the feat/snap-bridge-url-sanitizing branch from 850ba42 to 7376280 Compare October 11, 2024 15:14
@ccharly
Copy link
Collaborator Author

ccharly commented Oct 11, 2024

@metamaskbot publish-preview

@ccharly ccharly force-pushed the feat/snap-bridge-url-sanitizing branch from 7376280 to 91c511c Compare October 11, 2024 15:31
@ccharly
Copy link
Collaborator Author

ccharly commented Oct 11, 2024

@metamaskbot publish-preview

@ccharly ccharly force-pushed the feat/snap-bridge-url-sanitizing branch from 91c511c to d5a036e Compare October 11, 2024 15:37
@ccharly
Copy link
Collaborator Author

ccharly commented Oct 11, 2024

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/keyring-api": "8.1.3-d5a036e",
  "@metamask-previews/eth-hd-keyring": "7.0.4-d5a036e",
  "@metamask-previews/eth-ledger-bridge-keyring": "5.0.1-d5a036e",
  "@metamask-previews/eth-simple-keyring": "6.0.5-d5a036e",
  "@metamask-previews/eth-trezor-keyring": "4.0.0-d5a036e",
  "@metamask-previews/eth-snap-keyring": "4.3.6-d5a036e"
}

@ccharly ccharly force-pushed the feat/snap-bridge-url-sanitizing branch from bd191bc to 26f9984 Compare October 11, 2024 15:45
@ccharly ccharly force-pushed the feat/snap-bridge-url-sanitizing branch from 26f9984 to 1624353 Compare October 11, 2024 15:46
@ccharly ccharly marked this pull request as ready for review October 11, 2024 15:56
@ccharly ccharly requested a review from a team as a code owner October 11, 2024 15:56
@ccharly ccharly added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit c042b72 Oct 11, 2024
24 checks passed
@ccharly ccharly deleted the feat/snap-bridge-url-sanitizing branch October 11, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danroc danroc danroc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccharly @danroc