Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(keyring-api): update peer dependency @metamask/providers@^17.2.0 -> ^18.1.0 #76

Merged
merged 1 commit into from
Oct 18, 2024
Merged

chore(keyring-api): update peer dependency @metamask/providers@^17.2.0 -> ^18.1.0 #76

merged 1 commit into from
Oct 18, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 18, 2024 •
edited
Loading

Bump @metamask/providers requirement to:

  • use @metamask/rpc-errors min 7.0.0 for consistent error handling
  • not have type error from @metamask/providers reference to readable-stream

Examples

@socket-security Socket Security
Copy link

socket-security bot commented Oct 18, 2024 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None +4 845 kB metamaskbot

View full report↗︎

@legobeat legobeat marked this pull request as ready for review October 18, 2024 11:35
@legobeat legobeat requested a review from a team as a code owner October 18, 2024 11:35
@legobeat legobeat added team-accounts This should be handled by the Accounts Team team-hardware-wallets This should be handled by the Hardware Wallets Team labels Oct 18, 2024
@ccharly ccharly changed the title peerDeps(keyring-api): @metamask/providers@^17.2.0->^18.1.0 chore(keyring-api): update peer dependency @metamask/providers@^17.2.0 -> ^18.1.0 Oct 18, 2024
@legobeat legobeat added this pull request to the merge queue Oct 18, 2024
@legobeat legobeat mentioned this pull request Oct 18, 2024
Closed
Merged via the queue into main with commit fa3f69c Oct 18, 2024
26 checks passed
@legobeat legobeat deleted the deps-providers-18 branch October 18, 2024 18:09
@legobeat legobeat mentioned this pull request Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccharly ccharly ccharly approved these changes

Assignees
No one assigned
Labels
team-accounts This should be handled by the Accounts Team team-hardware-wallets This should be handled by the Hardware Wallets Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @ccharly