fix: do not lower address for non-EVM accounts during account creation #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are adding the `SolAccountType` to support Solana account creation. --------- Co-authored-by: Charly Chevalier <[email protected]>
ccharly
force-pushed
the
fix/invalid-lower-cased-solana-address
branch
from
713e38b
to
38a0c5a
Compare
|
@metamaskbot publish-previews |
|
Preview builds have been published. See these instructions (from the Expand for full list of packages and versions. |
danroc
reviewed
Nov 8, 2024
danroc
reviewed
Nov 8, 2024
danroc
reviewed
Nov 8, 2024
gantunesr
previously approved these changes
Nov 8, 2024
zone-live
previously approved these changes
Nov 12, 2024
ccharly
dismissed stale reviews from zone-live and gantunesr
The base branch was changed.
danroc
reviewed
Nov 12, 2024
danroc
approved these changes
Nov 12, 2024
ccharly
commented
Nov 19, 2024
| throw new Error(`Account address '${account.address}' already exists`); | ||
| const address = normalizeAccountAddress(account); | ||
| if (await this.#callbacks.addressExists(address)) { | ||
| throw new Error(`Account address '${address}' already exists`); |
There was a problem hiding this comment.
Actually, this was a mistake, I should have used account.address here. Now the error message uses the "normalized" address, which might be different than the one in account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some non-EVM account's addresses might be case-sensitive like Solana.
We didn't have any issue with Bitcoin native segwit addresses (since they are lower-case already), but to avoid introducing this "lower-case" behavior everywhere we will only modify the address for EVM accounts.
cc: @aganglada