Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: user-operation-controller changelog typo #4989

Merged

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Nov 27, 2024

Explanation

The changelog for @metamask/user-operation-controller version 18.0.0 contains a typo. The entry for the version mistakenly mentions @metamask/accounts-controller instead of the correct package, @metamask/transaction-controller, for the bump.

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Gudahtt

This comment was marked as resolved.

@cryptodev-2s cryptodev-2s changed the title fix: user-operation-controller changelog typo chre: user-operation-controller changelog typo Nov 27, 2024
@cryptodev-2s cryptodev-2s changed the title chre: user-operation-controller changelog typo chore: user-operation-controller changelog typo Nov 27, 2024
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cryptodev-2s cryptodev-2s merged commit 923f0e4 into main Nov 27, 2024
125 checks passed
@cryptodev-2s cryptodev-2s deleted the cryptodev2s/fix-user-operation-controller-changelog-typo branch November 27, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants