Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanks very very good #1751

Open
HumayunMhmadi opened this issue Nov 27, 2024 · 0 comments
Open

Thanks very very good #1751

HumayunMhmadi opened this issue Nov 27, 2024 · 0 comments

Comments

@HumayunMhmadi
Copy link

Thanks, looks great!

I only have three nitpicks:

  1. formatting (see suggestions)

  2. I am not sure if all these CSS properties are required. However, I think we already had some unnecessary CSS properties before so this is not a regression.

  3. I think we also should do something for the logos in the configuration page since they can also get quite large:

2024-11-27-025915_1920x1080_scrot

For example, we could do something like this:

diff --git a/pages/settings/wallets/[wallet].js b/pages/settings/wallets/[wallet].js
index b3bcca62..98cc2bf5 100644
--- a/pages/settings/wallets/[wallet].js
+++ b/pages/settings/wallets/[wallet].js
@@ -19,6 +19,7 @@ import validateWallet from '@/wallets/validate'
 import { ValidationError } from 'yup'
 import { useFormikContext } from 'formik'
 import { useWalletImage } from '@/components/wallet-image'
+import styles from '@/styles/wallet.module.css'
 
 export const getServerSideProps = getGetServerSideProps({ authRequired: true })
 
@@ -72,7 +73,7 @@ export default function WalletSettings () {
   return (
     <CenterLayout>
       {image
-        ? <img {...image} className='pb-3 px-2 mw-100' />
+        ? <img {...image} className={styles.walletBanner} />
         : <h2 className='pb-2'>{wallet.def.card.title}</h2>}
       <h6 className='text-muted text-center pb-3'><Text>{wallet.def.card.subtitle}</Text></h6>
       <Form
diff --git a/styles/wallet.module.css b/styles/wallet.module.css
index 62d1da47..df6c34f0 100644
--- a/styles/wallet.module.css
+++ b/styles/wallet.module.css
@@ -49,6 +49,11 @@
   line-height: 1;
 }
 
+.walletBanner {
+  max-width: 256px;
+  max-height: 100px;
+  padding-bottom: 1rem;
+}
 
 .badge {
   color: var(--theme-grey) !important;

2024-11-27-025936_1920x1080_scrot

What do you think?

Originally posted by @ekzyis in stackernews/stacker.news#1654 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant