Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Contract Deployment - An incorrect warning is displayed when deploying a contract: You're sending call data to an address that isn't a contract. #30359

Open
seaona opened this issue Feb 17, 2025 · 1 comment
Assignees
Labels
regression-RC-12.13.0 Regression bug that was found in release candidate (RC) for release 12.13.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug Something isn't working

Comments

@seaona
Copy link
Contributor

seaona commented Feb 17, 2025

Describe the bug

Whenever I deploy a contract, I see the warning You're sending call data to an address that isn't a contract.. Regular contract deployments (not using create/2) will be always flagged as "address that isn't a contract" as there's no contract address until the tx is executed.

Expected behavior

No warning displayed for Contract Deployments

Screenshots/Recordings

Image

contract-deployment-warning.mp4

Steps to reproduce

  1. Select Mainnet
  2. Go to the test dapp
  3. Trigger a contract deployment
  4. See warning You're sending call data to an address that isn't a contract.

Error messages or log output

Detection stage

During release testing

Version

12.13.0

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

@seaona seaona added Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug Something isn't working labels Feb 17, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Feb 17, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Feb 17, 2025
@seaona seaona added the regression-RC-12.13.0 Regression bug that was found in release candidate (RC) for release 12.13.0 label Feb 17, 2025
@bschorchit bschorchit added release-blocker This bug is blocking the next release and removed release-blocker This bug is blocking the next release labels Feb 17, 2025
@bschorchit
Copy link

bschorchit commented Feb 18, 2025

Good catch! We should ignore this alert if the transaction is a contract deployment. Ok if I assign this to you, @pedronfigueiredo ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-RC-12.13.0 Regression bug that was found in release candidate (RC) for release 12.13.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug Something isn't working
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

3 participants