-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rndemos): update metro config to support eciesjs crypto imports #1147
base: main
Are you sure you want to change the base?
Conversation
Added custom resolvers for '@ecies/ciphers/aes' and '@ecies/ciphers/chacha' in metro.config.js.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
- Coverage 74.26% 74.14% -0.12%
==========================================
Files 181 181
Lines 4297 4297
Branches 1052 1052
==========================================
- Hits 3191 3186 -5
- Misses 1106 1111 +5 ☔ View full report in Codecov by Sentry. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@noble/[email protected] |
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is network access?This module accesses the network. Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
Quality Gate passedIssues Measures |
Description
Problem
The recent update to
eciesjs
v0.4.12 switched from usingcrypto
tonode:crypto
, causing React Native examples to fail due to missing module resolution. This PR fixes the module resolution in the React Native environment.Changes
@ecies/ciphers/aes
and@ecies/ciphers/chacha
eciesjs
dependency from v0.4.4 to v0.4.12node:crypto
alias to resolve toreact-native-crypto
base64Icon
in DappMetadata type (useiconUrl
instead)Implementation Details
Metro Configuration Updates
Breaking Changes
Deprecations
base64Icon
in DappMetadata is now deprecated in favor oficonUrl