Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZIP-archive and directory sorting is broken. #950

Open
TpaBkaY opened this issue Jan 13, 2025 · 6 comments
Open

ZIP-archive and directory sorting is broken. #950

TpaBkaY opened this issue Jan 13, 2025 · 6 comments

Comments

@TpaBkaY
Copy link
Contributor

TpaBkaY commented Jan 13, 2025

@okdana What is the main idea to roll back these changes? What problem does it fix?

Originally posted by @TpaBkaY in 1017633

@okdana
Copy link
Contributor

okdana commented Jan 13, 2025

hi @TpaBkaY. like i mentioned in #943, the mister menu treats zip archives almost exactly like directories for the purposes of navigation, so it kind of pressures you to do the same. which i have been for the last 5 years

the particular use case i have that the previous change broke is a file structure like this:

1 rarely updated files.zip
2 frequently updated files/
3 rarely updated files.zip
1 regular file.bin

with the previous change it became:

2 frequently updated files/
1 rarely updated files.zip
3 rarely updated files.zip
1 regular file.bin

which seems like 'the worst of both worlds' to me

besides breaking my particular habits it just doesn't seem useful -- what benefit does sorting zip files separately from other files and directories provide? it's not a file manager, the only thing you can do is navigate, and again zips are exactly the same as directories for that purpose. so why distinguish them? is there another use case i don't understand?

i mentioned in #943 that i would personally prefer that zips get treated just like any other file, and that they automatically select a file inside if it's the only one there. this is similar to how many software emulators behave. if there was an ini setting to toggle between that and the current behaviour (and maybe the one from your previous change? if it's actually a common use case?) i think that could make everyone happy. but i had the feeling that sorgelig prefers not to add lots of ini settings so i made the less drastic change

@sorgelig
Copy link
Member

It's a bad behavior to give the same name for directory and zip. If you are aware that zip is shown as a directory then give a little different name.

@okdana
Copy link
Contributor

okdana commented Jan 15, 2025

not sure if you're referring to me, but if so i haven't done that

@birdybro
Copy link
Member

birdybro commented Jan 15, 2025

Here's an alternative example. Here is how it functioned before @okdana's changes

Favorites\
Europe.zip
Japan.zip
USA.zip

This is the way it is sorted on most operating systems.

However, @okdana's change makes it so the sorting would look like this instead:

Europe.zip
Favorites\
Japan.zip
USA.zip

In this use case @okdana likes to add roms to the favorites folder, but the roms in the zip files are static and don't need to be changed. @okdana wants to make this the sorting preference because MiSTer's UX already treats zip files as folders/directories in how the user interacts with them.

@sorgelig
Copy link
Member

This is the way it is sorted on most operating systems.

on operating systems zips are shown as files, not as folders.
I'm not 100% sure what sorting is better. Basically, if zips are shown as folders then it's better if it sorted with folders together.

@birdybro
Copy link
Member

on operating systems zips are shown as files, not as folders.

Yes, that's what I meant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants