Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognizers should register their names to allow dynamic pipeline creation. #5

Open
MikeHopcroft opened this issue Oct 15, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@MikeHopcroft
Copy link
Owner

This enables a couple of scenarios

  1. Test files can include a pipeline specifier that lists the recognizers required for the test. This allows testing of individual recognizers and combinations of recognizers.
  2. The CompositeRecognizer can produce more specific logging information by naming the recognizer at each stage.
@MikeHopcroft MikeHopcroft added the enhancement New feature or request label Oct 15, 2018
@MikeHopcroft
Copy link
Owner Author

With this feature, recognizers could also add their names as prefixes to logging messages. Right now we see

14 items contributed 143 aliases.
5 items contributed 22 aliases.
16 items contributed 31 aliases.
60 items contributed 208 aliases.

instead of

EntityRecognizer: 14 items contributed 143 aliases.
AttributeRecognizer: 5 items contributed 22 aliases.
QuantityRecognizer: 16 items contributed 31 aliases.
IntentRecognizer: 60 items contributed 208 aliases.

@MikeHopcroft
Copy link
Owner Author

CompositeRecognizer should also use the names for logging.

@MikeHopcroft
Copy link
Owner Author

We no longer have a recognizer pipeline, but the comments, above, may still apply to domains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant