fix: metatracks always failing equality

Author: jtpavlock

moe/library/album.py

@@ -209,7 +209,7 @@ def merge(self, other: "MetaAlbum", overwrite: bool = False) -> None:
 
     def __eq__(self, other) -> bool:
         """Compares MetaAlbums by their fields."""
-        if type(self) != type(other):  # noqa: E721
+        if not isinstance(other, MetaAlbum):
             return False
 
         for field in self.fields:

moe/library/track.py

@@ -219,7 +219,7 @@ def merge(self, other: "MetaTrack", overwrite: bool = False):
 
     def __eq__(self, other) -> bool:
         """Compares Tracks by their fields."""
-        if not isinstance(other, Track):
+        if not isinstance(other, MetaTrack):
             return False
 
         for field in self.fields:

tests/library/test_album.py

@@ -412,6 +412,20 @@ def test_default(self):
 class TestEquality:
     """Test equality of albums."""
 
+    def test_meta_equals(self):
+        """Meta Albums with the same fields are equal."""
+        album1 = MetaAlbum(artist="equals")
+        album2 = MetaAlbum(artist="equals")
+
+        assert album1 == album2
+
+    def test_meta_not_equals(self):
+        """Meta Albums with different fields are not equal."""
+        album1 = MetaAlbum(artist="equals")
+        album2 = MetaAlbum(artist="not equal")
+
+        assert album1 != album2
+
     def test_equals(self):
         """Albums with the same fields are equal."""
         album1 = album_factory()

tests/library/test_track.py

@@ -224,6 +224,22 @@ def test_missing_disc_total(self, tmp_config):
 class TestEquality:
     """Test equality of tracks."""
 
+    def test_meta_equals(self):
+        """Meta Tracks with the same metadata are equal."""
+        album = MetaAlbum(artist="meta_artist")
+        track1 = MetaTrack(album, 1)
+        track2 = MetaTrack(album, 1)
+
+        assert track1 == track2
+
+    def test_meta_not_equals(self):
+        """Meta Tracks with different metadata are not equal."""
+        album = MetaAlbum(artist="meta_artist")
+        track1 = MetaTrack(album, 1)
+        track2 = MetaTrack(album, 2)
+
+        assert track1 != track2
+
     def test_equals(self):
         """Tracks with the same metadata are equal."""
         track1 = track_factory()