Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Time test for relative mode #274

Open
2wheeh opened this issue Mar 13, 2024 · 1 comment
Open

Fix Time test for relative mode #274

2wheeh opened this issue Mar 13, 2024 · 1 comment
Assignees
Labels
bug Something isn't working ui Something about UI

Comments

@2wheeh
Copy link
Collaborator

2wheeh commented Mar 13, 2024

Content

relative time 계산을 위해 dayjs에 의존하고 있습니다.

dayjs 에서 상대시간을 계산하는 방식이 단지 초단위의 시간차 계산이 아닌 더 디테일하게 조정하는 방식이라 현재 테스트에서 간헐적으로 에러가 발생합니다.
(참고: https://day.js.org/docs/en/customization/relative-time)

해당 디테일은 dayjs 에 의존하기로 결정한 만큼, dayjs 동작에 관한 테스트 일부를 제거하겠습니다.

@2wheeh 2wheeh added bug Something isn't working ui Something about UI labels Mar 13, 2024
@2wheeh 2wheeh self-assigned this Mar 13, 2024
@2wheeh 2wheeh added this to Alpha Mar 13, 2024
@2wheeh 2wheeh moved this to Todo in Alpha Mar 13, 2024
@2wheeh
Copy link
Collaborator Author

2wheeh commented Mar 13, 2024

로컬에선 재현이 안되네요... 음

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui Something about UI
Projects
Status: Todo
Development

No branches or pull requests

1 participant