Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong truncation_cutoff in gen_samples_next3d.py #21

Open
wamiq-reyaz opened this issue Jun 9, 2023 · 1 comment
Open

Wrong truncation_cutoff in gen_samples_next3d.py #21

wamiq-reyaz opened this issue Jun 9, 2023 · 1 comment

Comments

@wamiq-reyaz
Copy link

In the file gen_samples_next3d.py,

@click.option('--trunc-cutoff', 'truncation_cutoff', type=int, help='Truncation cutoff', default=14, show_default=True)

the truncation cutoff is set to 14, meaning that the truncation is only applied to the texture_ws and not the eg3d_ws, because of this line

x[:, :truncation_cutoff] = self.w_avg.lerp(x[:, :truncation_cutoff], truncation_psi)

Is my understanding correct? I think because of this, we get a prominent stitching artifact where the FLAME rasterized texture and the static rendered features meet.

An example of what I mean:

@MrTornado24
Copy link
Owner

Hi, it's a good question! I'll take a look. What is your example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants