Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getWalletVerbose: errors are not handled #86

Open
vovapi opened this issue Jul 25, 2018 · 0 comments
Open

getWalletVerbose: errors are not handled #86

vovapi opened this issue Jul 25, 2018 · 0 comments

Comments

@vovapi
Copy link

vovapi commented Jul 25, 2018

Errors are not handled (particularly in Ether case):

EventGetAdressNonce errors are simply ignored (if EventGetAdressBalance has nil error):

Multy-back/client/rest.go

Lines 1404 to 1409 in 527bb21

case currencies.ETHTest:
nonce, err = restClient.ETH.CliTest.EventGetAdressNonce(context.Background(), &adr)
amount, err = restClient.ETH.CliTest.EventGetAdressBalance(context.Background(), &adr)
case currencies.ETHMain:
nonce, err = restClient.ETH.CliMain.EventGetAdressNonce(context.Background(), &adr)
amount, err = restClient.ETH.CliMain.EventGetAdressBalance(context.Background(), &adr)

GetAllWalletEthTransactions simply not handled

Multy-back/client/rest.go

Line 1434 in 527bb21

err = restClient.userStore.GetAllWalletEthTransactions(user.UserID, currencyId, networkId, &userTxs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vovapi