From 9088903e1b4067afa783ff995098d7116e18ff46 Mon Sep 17 00:00:00 2001 From: Muntashir Al-Islam Date: Fri, 15 Sep 2023 22:54:59 +0600 Subject: [PATCH] [CI] Update Java to 17 Updated BUILDING to reflect the dependency changes. Signed-off-by: Muntashir Al-Islam --- .github/workflows/codeql.yml | 2 +- .github/workflows/debug_build.yml | 2 +- .github/workflows/lint.yml | 2 +- .github/workflows/tests.yml | 2 +- BUILDING.rst | 13 ++++++------- CONTRIBUTING.rst | 4 ++-- 6 files changed, 12 insertions(+), 13 deletions(-) diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 4ddec7fbe9e..6492d46edef 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -32,7 +32,7 @@ jobs: uses: actions/setup-java@v3 with: distribution: 'zulu' - java-version: 11 + java-version: 17 cache: 'gradle' - name: Initialize CodeQL uses: github/codeql-action/init@v2 diff --git a/.github/workflows/debug_build.yml b/.github/workflows/debug_build.yml index 888fb695edd..0b24b1caedb 100644 --- a/.github/workflows/debug_build.yml +++ b/.github/workflows/debug_build.yml @@ -28,7 +28,7 @@ jobs: uses: actions/setup-java@v3 with: distribution: 'zulu' - java-version: 11 + java-version: 17 cache: 'gradle' - name: Grant execute permission for gradlew run: chmod +x gradlew diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index f2a76fd1591..efb1c17bcdd 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -30,7 +30,7 @@ jobs: uses: actions/setup-java@v3 with: distribution: 'zulu' - java-version: 11 + java-version: 17 cache: 'gradle' - name: Grant execute permission for gradlew run: chmod +x gradlew diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 0798330d429..0b72d92bb88 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -30,7 +30,7 @@ jobs: uses: actions/setup-java@v3 with: distribution: 'zulu' - java-version: 11 + java-version: 17 cache: 'gradle' - name: Grant execute permission for gradlew run: chmod +x gradlew diff --git a/BUILDING.rst b/BUILDING.rst index 945949b09ea..a7883c0d689 100644 --- a/BUILDING.rst +++ b/BUILDING.rst @@ -7,12 +7,11 @@ Building App Manager Requirements ============ -* **Hardware:** Any computer with 4GB RAM (8GB recommended) and 20GB storage +* **Hardware:** Any computer with 8 GB RAM and 20 GB storage * **Operating system:** Linux/macOS (no support for Windows) -* **Software:** Android Studio/IntelliJ IDEA, Gradle, Latex, tex4ht, JDK 11+ - (JDK 14 recommended) +* **Software:** Android Studio/IntelliJ IDEA, Gradle, Latex, pandoc, JDK 17+ * **Active network connection:** Depending on your development environment, - this may cross 20 Gigabytes of data. + you may need at least 20 GB data package. macOS ===== @@ -81,10 +80,10 @@ Create Bundled App To create a bundled app in APKS format, run the following command:: - ./scripts/aab_to_apks.sh preRelease + ./scripts/aab_to_apks.sh type -Replace ``prePelease`` with ``release`` or ``debug`` based on your -requirements. It will ask for KeyStore credentials interactively. +Replace ``type`` with ``release`` or ``debug`` based on your requirements. +It will ask for KeyStore credentials interactively. The script above will also generate a universal APK. diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index b4071423fc8..5b72b677818 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -4,7 +4,7 @@ Contributing ============ -You are welcome contribute to App Manager! This doesn't mean that you need +You are welcome contribute to App Manager! This doesn't mean that you need coding skills. You can contribute to App Manager by creating helpful issues, attending discussions, improving documentations and translations, making icon for icon packs, adding unrecognised libraries or ad/tracking signatures, @@ -46,7 +46,7 @@ Rules We also support most of the `commit message conventions`_ from Linux. App Manager is a legal software and its contributions are protected by - copyright laws. Consider using real credentials i.e. real name and email as + copyright laws. Consider using real credentials ie. real name and email as we may be required to delete your valuable contributions in the event of introducing new license or adding exceptions to the existing license.