Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio processing when saving #112

Open
1vanK opened this issue Jul 31, 2024 · 0 comments
Open

Audio processing when saving #112

1vanK opened this issue Jul 31, 2024 · 0 comments

Comments

@1vanK
Copy link

1vanK commented Jul 31, 2024

I set the video size to 12 hours and the batch size to 1 hour (I would set it higher, but that's the maximum).
I save the batches to the DCIM folder. I almost always end up with a recording of just one batch.
However, when saving, there is still a long audio processing and creation of the resulting file (essentially just a copy of the batch) in the same folder. Is it possible to just leave the batch as the result when saving if there is only one batch?

Myzel394 added a commit that referenced this issue Aug 5, 2024
Related to #112

Update the `saveRecording` function in `RecorderEventsHandler.kt` to handle the case where there is only one batch and skip processing.

* Add a check to see if there is only one batch and skip concatenation if true.
* Modify the `saveRecording` function to use the single batch file path if there is only one batch.
* Update the `saveAudioFile` and `saveVideoFile` calls to use the single batch file path if there is only one batch.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/Myzel394/Alibi/issues/112?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant