From e1ffda33cb73afccfcd1e2e853555457142ce0c0 Mon Sep 17 00:00:00 2001
From: Mythicaeda <theresa.kamerman@jpl.nasa.gov>
Date: Mon, 26 Feb 2024 08:01:42 -0800
Subject: [PATCH] Update GH Actions in Workflows to Node 20 (#1135)

Update GH Actions to Use Node20 Versions
---
 .github/workflows/lint.yml          |  4 ++--
 .github/workflows/publish.yml       | 14 +++++++-------
 .github/workflows/security-scan.yml | 10 +++++-----
 .github/workflows/test.yml          | 18 +++++++-----------
 4 files changed, 21 insertions(+), 25 deletions(-)

diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index f8cd5ff281..4078143c18 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -17,9 +17,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout Repo
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Setup Node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 'lts/*'
           cache: npm
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
index 7a47efa16d..4b76bee3b7 100644
--- a/.github/workflows/publish.yml
+++ b/.github/workflows/publish.yml
@@ -19,8 +19,8 @@ jobs:
       contents: read
       packages: write
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
           node-version: 'lts/*'
           cache: npm
@@ -31,20 +31,20 @@ jobs:
       - name: Install Production Dependencies
         run: npm ci --production
       - name: Login to the Container Registry
-        uses: docker/login-action@v2
+        uses: docker/login-action@v3
         with:
           registry: ${{ env.REGISTRY }}
           username: ${{ github.actor }}
           password: ${{ github.token }}
       - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v2
+        uses: docker/setup-buildx-action@v3
       - name: Extract Metadata (tags and labels) for Docker
         id: meta
-        uses: docker/metadata-action@v4
+        uses: docker/metadata-action@v5
         with:
           images: ${{ env.REGISTRY }}/${{ github.repository }}
       - name: Build Docker Image
-        uses: docker/build-push-action@v3
+        uses: docker/build-push-action@v5
         with:
           context: .
           load: true
@@ -58,7 +58,7 @@ jobs:
           ignore-unfixed: true
           severity: 'CRITICAL'
       - name: Push Docker Image
-        uses: docker/build-push-action@v3
+        uses: docker/build-push-action@v5
         with:
           context: .
           platforms: linux/amd64,linux/arm64
diff --git a/.github/workflows/security-scan.yml b/.github/workflows/security-scan.yml
index 6df366a1c7..02bae210df 100644
--- a/.github/workflows/security-scan.yml
+++ b/.github/workflows/security-scan.yml
@@ -28,22 +28,22 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@v2
+        uses: github/codeql-action/init@v3
         with:
           languages: ${{ matrix.language }}
       - name: Autobuild
-        uses: github/codeql-action/autobuild@v2
+        uses: github/codeql-action/autobuild@v3
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@v2
+        uses: github/codeql-action/analyze@v3
       - name: NASA Scrub
         run: |
           pip install nasa-scrub
           python3 -m scrub.tools.parsers.translate_results /home/runner/work/aerie-ui/results/*.sarif /home/runner/work/aerie-ui/results/codeql.scrub ${{ github.workspace }} scrub
           python3 -m scrub.tools.parsers.csv_parser /home/runner/work/aerie-ui/results
       - name: Upload Security Scan Results
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: Security Scan Results
           path: /home/runner/work/aerie-ui/results/*
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index b77198fb53..31b5c14591 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -26,9 +26,9 @@ jobs:
     environment: test-workflow
     steps:
       - name: Checkout Repo (UI)
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Setup Node (UI)
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 'lts/*'
           cache: npm
@@ -47,18 +47,14 @@ jobs:
         run: npm run test:e2e
       - name: Test (unit)
         run: npm run test:unit
-      - name: Upload Results (Test - e2e)
+      - name: Upload Results
         if: always()
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: Test Results
-          path: '**/e2e-test-results'
-      - name: Upload Results (Test - unit)
-        if: always()
-        uses: actions/upload-artifact@v3
-        with:
-          name: Test Results
-          path: '**/unit-test-results'
+          path: |
+            **/e2e-test-results
+            **/unit-test-results
       - name: Print Logs for Services (Aerie)
         if: always()
         run: docker compose -f docker-compose-test.yml logs -t