Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design for Plan upload/download in GUI #1344

Closed
dandelany opened this issue Jun 21, 2024 · 5 comments
Closed

Design for Plan upload/download in GUI #1344

dandelany opened this issue Jun 21, 2024 · 5 comments
Assignees
Labels
design Issues related to design tasks feature New feature or request

Comments

@dandelany
Copy link
Collaborator

dandelany commented Jun 21, 2024

Checked for duplicates

Yes - I've already checked

Alternatives considered

Yes - and alternatives don't suffice

Related problems

#1154
NASA-AMMOS/aerie#1318

Describe the feature request

UI Design ticket for #1154 - we need to design a workflow for allowing users to download and upload Plan json files via the web UI. This is currently only possible using the API + aerie-cli tool, but we've gotten feedback from users that they'd like to use the UI for this too. @Mythicaeda described it well in the implementation ticket (#1154) so i'll copy her notes here:

  • Allow users to download a json representation of a plan, its activities with arguments, and tags. This download functionality should be exposed within the plan page and in the table of plans.
  • Allow users to upload a plan json file. This will involve adding an upload button to the plans page and allowing a user to specify a model and give the plan an alternative name if the plan name is already taken.

Sending to @lklyne to take a look - let me know if any further explanation is needed.

Sidenote: we also talked about supporting general file upload/download, but I think the UI design for that will be pretty different & therefore deserves a separate issue.

Design Direction

  • Add import button to right side of header in plan creation panel. Clicking this opens the browser's file picker.
  • If a file is added, populate available fields. Show a new item at the top with the file name and option to clear. Update the button text to show Create plan from .json
  • If errors occur, surface these with a banner at the top of the plan when opened. This will use the same treatment as our activity / model mismatch banner.
  • Show option to export form plan page using export icon at the right of the row on hover.
  • Show export option in plan dropdown when a plan is open.
  • Show export option in the plan metadata panel in the header.
  • Show progress spinner while plan is being exported.

https://www.figma.com/design/VR3isVdXGbUC5YQ114jB0z/Aerie-%231344-Plan-upload%2Fdownload?node-id=93-1051&t=bF6Q1y7CuqvFwnjx-1

@dandelany dandelany added the feature New feature or request label Jun 21, 2024
@dandelany dandelany added design Issues related to design tasks feature New feature or request and removed feature New feature or request labels Jun 21, 2024
@dandelany dandelany added this to Aerie Jun 21, 2024
@github-project-automation github-project-automation bot moved this to Todo in Aerie Jun 21, 2024
@ewferg
Copy link

ewferg commented Jun 21, 2024

If we provide a json format for download, what are our plans for documenting that specification/schema? Do we consider a similar download for a sim data set?

@cartermak
Copy link
Member

Sharing some input: it would be nice if the logic to map between the standalone plan JSON and the Hasura-structured data were provided by a back-end service instead of the UI. This would reduce the code duplication between Aerie-CLI and Aerie-UI, and dedicated Hasura actions for upload/download would allow users who interact via the API outside of Aerie-CLI to leverage the feature, too.

@cartermak
Copy link
Member

Another consideration: should the plan come with the simulation configuration? I was pondering adding sim config to the Aerie-CLI JSON plan format already. (See NASA-AMMOS/aerie-cli#128)

@lklyne
Copy link
Contributor

lklyne commented Jul 9, 2024

@lklyne lklyne moved this from Todo to In Review in Aerie Jul 18, 2024
@lklyne
Copy link
Contributor

lklyne commented Jul 19, 2024

Goals

  • Add ui for exporting/downloading and importing/uploading a plans json.
  • Show progress and potential errors during upload and download process

image
Interface

  • Upload button in plan creation panel (built)
  • Download button in plan metadata (built)
  • How do we show validation? Need to get details on what errors could come up
  • Clicking a plan in the plan table shows the details

@lklyne lklyne moved this from In Review to Done in Aerie Aug 1, 2024
@lklyne lklyne moved this from Done to In Review in Aerie Aug 1, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Aerie Aug 1, 2024
@dandelany dandelany removed the status in Aerie Aug 1, 2024
@mattdailis mattdailis moved this to Done in Aerie Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Issues related to design tasks feature New feature or request
Projects
Status: Done
Development

No branches or pull requests

5 participants