Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import SATF Library Sequence #1592

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Import SATF Library Sequence #1592

wants to merge 7 commits into from
+176 −15

Conversation

goetzrrGit
Copy link
Contributor

@goetzrrGit goetzrrGit commented Jan 14, 2025 •
edited
Loading

Closes #1591

Library Sequence Modal:

  • Introduced a new modal for importing a library sequence file.
  • Integrated the library modal with workspaces for seamless interaction.

Linting Bugfix:

  • Fixed an issue where the linter incorrectly reported errors for values within a valid range when multiple ranges were defined.
  • Fixed an issue where the linter incorrectly reported errors for command stems with no arguments.

Autocomplete Bugfix:

  • Improved autocomplete functionality to allow completion even with invalid variable types. The user will be notified of the invalid type within the editor and will need to manually correct it.

SATF/SASF Library

  • Fixed an issue where we were not generating the @model correctly.

TESTING

  • Download the attach file (banana_library.txt)
  • Rename it to banana_library.satf
  • Create a new workspace
  • In the middle panel underneath the 'create sequence' you should see a 'import library'
  • Click on 'import library' and select a parcel and library file ex. banana_library.satf
  • Verify the library gets imported and you see 3 sequences created

banana_library.txt

@goetzrrGit goetzrrGit added feature New feature or request sequencing Anything related to the sequencing domain labels Jan 14, 2025
@goetzrrGit goetzrrGit self-assigned this Jan 14, 2025
@goetzrrGit goetzrrGit requested a review from a team as a code owner January 14, 2025 21:49
@goetzrrGit goetzrrGit requested a review from AaronPlave January 14, 2025 21:49
@cohansen
Copy link
Contributor

Is this branch supposed to merge into #1574? It looks like a lot of the same changes.

@goetzrrGit
Bugfix allow for paths in Headers
405ca45
@goetzrrGit
Library Sequence Modal
f5db855 
This modal allows you to select a parcel and import a library sequence file
@goetzrrGit
Hook up the library modal to workspaces
b86da46
@goetzrrGit
Fixed incorrect linting errors when multiple ranges are defined.
b238184 
The linter incorrectly reported errors for values within a valid range when multiple ranges were defined. For example, if the ranges were 5-10 and 11-20, the linter would erroneously flag the value 8 as invalid because it falls outside the 11-20 range, even though it is valid within the 5-10 range.
@goetzrrGit
Improved autocomplete functionality by allowing completion even with …
f26f2e5 
…invalid variable types.

Allow autocomplete to succeed and show the ERROR parameter value. The user will see this error in the editor and manually have to fix it.
@goetzrrGit
Fixed linter error for commands without arguments.
3bcb544 
The linter will complain if there is a command with no arguments even though the command itself doesn't have any argument defined in the command dictionary.
@goetzrrGit
Fix @model generation.
98330e2 
There shouldn't be any parenthesis and commas in the SeqN generation
@goetzrrGit
Copy link
Contributor Author

Is this branch supposed to merge into #1574? It looks like a lot of the same changes.

Yeah it is branched from 1574 and since that was merged in the first 4 fell off. It should now all be new code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cohansen cohansen Awaiting requested review from cohansen

@duranb duranb Awaiting requested review from duranb

@joswig joswig Awaiting requested review from joswig

@AaronPlave AaronPlave Awaiting requested review from AaronPlave AaronPlave is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

At least 1 approving review is required to merge this pull request.

Assignees

@goetzrrGit goetzrrGit

Labels
feature New feature or request sequencing Anything related to the sequencing domain
Projects
Aerie
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import SATF Library Sequences Prototype
2 participants
@goetzrrGit @cohansen