Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up SQL scripts under amp-sql #103

Closed
BrianSipos opened this issue Aug 7, 2024 · 2 comments · Fixed by #159
Closed

Clean up SQL scripts under amp-sql #103

BrianSipos opened this issue Aug 7, 2024 · 2 comments · Fixed by #159
Assignees
Labels
sustainment Long-term sustainment activities and technical debt removal
Milestone

Comments

@BrianSipos
Copy link
Collaborator

The current amp-sql/Dockerfile renames a bunch of individual files rather than giving them appropriate names in the repo itself and using a COPY postgres/Database_Scripts/Tables/*.sql ... and similar to get them into the image.

There also appear to be abandoned Dockerfile and docker-compose.yml files in that file tree which should be removed if they are not actually in use.

This is a longer-term sustainment improvement and not a defect.

@BrianSipos BrianSipos added the sustainment Long-term sustainment activities and technical debt removal label Aug 7, 2024
@BrianSipos BrianSipos added this to the ANMS v1.2.0 milestone Aug 7, 2024
@BrianSipos BrianSipos added this to ANMS Aug 7, 2024
@BrianSipos BrianSipos moved this to Todo in ANMS Aug 13, 2024
@BrianSipos BrianSipos removed the status in ANMS Aug 22, 2024
@BrianSipos
Copy link
Collaborator Author

The renaming will simplify the Dockerfile contents, and the files themselves should be relocated into the dtnma-tools repository if they are directly needed by the AMP Manager runtime. I don't know if there is a split that some are needed and some not, or if they are just all needed by AMP Manager.

@mfarina1
Copy link
Collaborator

mfarina1 commented Oct 9, 2024

Relevant to ANMS backend dev because it's about updating and fixing the amp-sql database portion of the ANMS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sustainment Long-term sustainment activities and technical debt removal
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants