Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ION NM fails to handle hex string with blank space #11

Closed
d-linko opened this issue Sep 18, 2023 · 1 comment · Fixed by #69
Closed

ION NM fails to handle hex string with blank space #11

d-linko opened this issue Sep 18, 2023 · 1 comment · Fixed by #69
Assignees
Labels
bug Something isn't working CRIT-3 Defect has moderate to mild impact on usability of delivered software for mission operations.
Milestone

Comments

@d-linko
Copy link
Contributor

d-linko commented Sep 18, 2023

When the ANMS sends to ION a hex sequence that contains a blank space, e.g. 0xc11541050502252381871819410000 (space at the end) the result is a log message from docker exec ion-manager journalctl --unit ion-nm-mgr --since today similar to:

Mar 17 14:42:27 ion-manager nm_mgr[77]: [nm/shared/utils/utils.c:193] x utils_atox x Non-hex character:
Mar 17 14:42:27 ion-manager nm_mgr[77]: [nm/shared/utils/utils.c:407] x utils_string_to_hex Can't AtoX 0 .
@d-linko d-linko added the CRIT-3 Defect has moderate to mild impact on usability of delivered software for mission operations. label Sep 18, 2023
@d-linko d-linko added this to ANMS Sep 18, 2023
@BrianSipos BrianSipos added this to the ANMS v1.1 milestone Sep 19, 2023
@BrianSipos BrianSipos moved this to Todo in ANMS Sep 26, 2023
@BrianSipos
Copy link
Collaborator

There is a manager patch which will avoid this issue and will allow multiple controls to be present in one HTTP body. The specific change to nm_rest.c was made in dtnma-tools repo and can be added to ANMS ION as a patch.

@BrianSipos BrianSipos added the bug Something isn't working label Oct 17, 2023
@d-linko d-linko moved this from Todo to In Progress in ANMS Nov 21, 2023
@d-linko d-linko self-assigned this Nov 21, 2023
@d-linko d-linko linked a pull request Feb 5, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in ANMS Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CRIT-3 Defect has moderate to mild impact on usability of delivered software for mission operations.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants