Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I want to get an error 400 and relevant suggestions when the properties I am using in the q and fields do not exist in the registry #363

Open
tloubrieu-jpl opened this issue Jul 20, 2023 · 1 comment
Assignees
Labels
icebox p.could-have requirement the current issue is a requirement

Comments

@tloubrieu-jpl
Copy link
Member

Checked for duplicates

No - I haven't checked

πŸ§‘β€πŸ”¬ User Persona(s)

Data User

πŸ’ͺ Motivation

...so that I can quickly identify my errors and correct them.

πŸ“– Additional Details

No response

Acceptance Criteria

Given
When I perform
Then I expect

βš™οΈ Engineering Details

No response

@al-niessner
Copy link
Contributor

@tloubrieu-jpl

This would require know what fields in the q, probably mostly knowable, then checking them against all known and generating errors. Do you really want this level of overhead for every check? The problem is that when you get 0 hits you do not know nor can you tell if the field does not exist but should, does not exist and should not, does exist but does not match criteria. The only of those three that a query to the registry table answers is does not exist and should not. Hence every q would have to be checked to see if the field names were bogus (as in typos or something where they do not exist because they should not exist).

What happens in an or and the user does not care about the typo it is really the other valid field they do care about? In other words, the user would be annoyed at best with 400 error because they know and do not care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icebox p.could-have requirement the current issue is a requirement
Projects
Status: ToDo
Development

No branches or pull requests

3 participants