You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While testing HiRISE PDS4 migration, validate current throws a warning for a valid jpeg2000 file extension (specifically the file extension "jp2"). This extension is used by several archives (e.g., HiRISE, MOLA, LOLA). JP2 files are still allowed in PDS4 but not as Product_Observational.
I think the topic veered down a couple unintended rabbit holes, but essentially the fix is shown here:
After looking at the Validate code, I think the update would simply be at (line 9):
from: J2C(Arrays.asList("j2c", "mj2", "mjp2")),
to: J2C(Arrays.asList("j2c", "jp2", "mj2", "mjp2")),
Acceptance Criteria
Given a JPEG2000 encoded image label referencing a product with the file extension JP2 (product.xml, product.jp2) When I performvalidate --target product.xml Then I expect the product to validate successfully
βοΈ Engineering Details
No response
π I&T
No response
The text was updated successfully, but these errors were encountered:
@thareUSGS do you have an example product we could add to our test suite? preferably very very small. would could probably even just add a zero byte product.
jordanpadams
changed the title
As a user, I want to see the JP2 file extension not issue a warning
As a user, I want to support the JP2 as an acceptable file extension per the PDS4 standards
Jan 9, 2025
Checked for duplicates
Yes - I've already checked
π§βπ¬ User Persona(s)
Data Engineer
πͺ Motivation
While testing HiRISE PDS4 migration, validate current throws a warning for a valid jpeg2000 file extension (specifically the file extension "jp2"). This extension is used by several archives (e.g., HiRISE, MOLA, LOLA). JP2 files are still allowed in PDS4 but not as Product_Observational.
The HiRISE team will only be using "jp2" files under Encoded_Image tagged correctly as "J2C" encoding within in Product_Browse and File_Area_Observational_Supplemental
To make sure this is clear, note that "J2C" is not used for the file extension but the encoding type.
π Additional Details
It was unclear if this was a topic that actually needed a DDWG vote. But, the topic was raised and voted on:
https://github.com/NASA-PDS/PDS4-CCB/issues/48
I think the topic veered down a couple unintended rabbit holes, but essentially the fix is shown here:
After looking at the Validate code, I think the update would simply be at (line 9):
from:
J2C(Arrays.asList("j2c", "mj2", "mjp2")),
to:
J2C(Arrays.asList("j2c", "jp2", "mj2", "mjp2")),
Acceptance Criteria
Given a JPEG2000 encoded image label referencing a product with the file extension JP2 (product.xml, product.jp2)
When I perform
validate --target product.xml
Then I expect the product to validate successfully
βοΈ Engineering Details
No response
π I&T
No response
The text was updated successfully, but these errors were encountered: