Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs_converter notes: obs_err mods #302

Open
hkershaw-brown opened this issue Oct 15, 2021 · 1 comment
Open

obs_converter notes: obs_err mods #302

hkershaw-brown opened this issue Oct 15, 2021 · 1 comment
Labels
Bug Something isn't working duplicated code same code in multiple places obs_converters converting observations to DART format

Comments

@hkershaw-brown
Copy link
Member

hkershaw-brown commented Oct 15, 2021

obs_error directory

  1. Duplicate file meteor_mod.f90:
    obs_converters/NCEP/netcdf/meteor_mod.f90
    obs_converters/MADIS/meteor_mod.f90

  2. obs_converters/obs_error directory:

The readme

IMPORTANT:
Each file should have the same module name; i.e. the source
file names will differ but the module name inside the file
must be the same across all modules in this directory.

All the subroutines must also have the same names and
calling sequence. They must return appropriate values 
for each observation type that is required.  
If errors for a new observation type is added, it should
be added to all the files in this directory.

ncep_obs_err_mod.f90 has more public routines than ecmwf_obs_err_mod.f90

public :: metar_pres_error,              &
              metar_rel_hum_error,           &
              metar_temp_error,              &
              metar_wind_error

dewpoint_obs_err_mod.f90 is different to ncep/ecmwf_obs_err_mod.f90

@hkershaw-brown hkershaw-brown added the duplicated code same code in multiple places label Oct 15, 2021
@hkershaw-brown hkershaw-brown changed the title obs_converter obs_error directory notes obs_converter notes Oct 15, 2021
@hkershaw-brown
Copy link
Member Author

hkershaw-brown commented Oct 15, 2021

obs_utilities:

#129

should these get built when you build model/work or observation_converter/work (or both). These utilities are hidden at the moment.

Edit #129 was fixed in pull request #348. These utilities are all in DART/assimilation_code/programs so they can be built with any model/converter.

@hkershaw-brown hkershaw-brown added build-system issues related to building dart and removed build-system issues related to building dart labels Apr 13, 2022
hkershaw-brown added a commit that referenced this issue May 16, 2022
see #302 for notes on different obs error files
@hkershaw-brown hkershaw-brown added the obs_converters converting observations to DART format label May 17, 2022
@hkershaw-brown hkershaw-brown changed the title obs_converter notes obs_converter notes: obs_err mods Apr 23, 2024
@hkershaw-brown hkershaw-brown added the Bug Something isn't working label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working duplicated code same code in multiple places obs_converters converting observations to DART format
Projects
None yet
Development

No branches or pull requests

1 participant