Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note on obstype terminology for quantity #834

Open
hkershaw-brown opened this issue Mar 5, 2025 · 0 comments
Open

Note on obstype terminology for quantity #834

hkershaw-brown opened this issue Mar 5, 2025 · 0 comments

Comments

@hkershaw-brown
Copy link
Member

There are places in the code where obstype is used, but the variable/argument is referring to qty

We've updated this in the template model, and when we refactor model_mods, but there is still a lot of 'obstype' hanging around in model_mods and fwd ops. Particularly for people using the QCEFF and debugging their runs, the loose naming type (for qty) adds an unneeded overhead to reading the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant