Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Rework version selection, especially in beats #313

Open
1 task done
widhalmt opened this issue Feb 7, 2024 · 0 comments
Open
1 task done

[Bug]: Rework version selection, especially in beats #313

widhalmt opened this issue Feb 7, 2024 · 0 comments
Labels
bug Something isn't working needs-triage Needs to be triaged
Milestone
0.1.0

Comments

@widhalmt
Copy link
Member

widhalmt commented Feb 7, 2024

Please try to fill out as much of the information below as you can. Thank you!

  • Yes, I've searched similar issues on GitHub and didn't find any.

Which version contains the bug?

No response

Describe the bug

If you check the code parts that install packages you will find that Beats have twice as many tasks as others. That's because they have support for latest in version.

So either we build something similar in all the roles (don't like the idea) or we get rid of the option to set version to latest. When building a solution, please consider #250 where we add code to first determine which version to install and then use this for all other packages.

How to recreate the bug?

Nothing really to recreate. Just review the code.
@widhalmt widhalmt added bug Something isn't working needs-triage Needs to be triaged labels Feb 7, 2024
widhalmt added a commit that referenced this issue Feb 7, 2024
@widhalmt
Enforce repos only with full stack
00d3c8e 
RPM installation automatically enabled the Elastic Stack repositories
this collection will add to a host. But if you have another tool to
manage your repositories, they might have other ids and names.

So I added separate installation tasks. If `elasticstack_full_stack` is
set to `true`, everything stays as it was. The task will forcefully
enable the repository and then install the package.

But if `elasticstack_full_stack` is set to `false` it will just ignore
the repository and expect the package to be available.

While working on this I found a different approach to choosing the
correct version in the `beats` role. I couldn't afford to fix it all in
a single PR so I opened #313 for this.

fixes #312
@widhalmt widhalmt mentioned this issue Feb 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 9, 2024
@widhalmt
Enforce repos only with full stack (#314)
f3ee73d 
RPM installation automatically enabled the Elastic Stack repositories
this collection will add to a host. But if you have another tool to
manage your repositories, they might have other ids and names.

So I added separate installation tasks. If `elasticstack_full_stack` is
set to `true`, everything stays as it was. The task will forcefully
enable the repository and then install the package.

But if `elasticstack_full_stack` is set to `false` it will just ignore
the repository and expect the package to be available.

While working on this I found a different approach to choosing the
correct version in the `beats` role. I couldn't afford to fix it all in
a single PR so I opened #313 for this.

fixes #312
@widhalmt widhalmt added this to the 0.1.0 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs-triage Needs to be triaged
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
1 participant
@widhalmt