Naming conventions for lambdas
#36
Comments
hdrake
added a commit
to hdrake/xwmt
that referenced
this issue
May 3, 2023
This completes the separation of the WaterMass class (consisting of the ds, grid, and variables/constants/methods related to thermodynamics and density) from the WaterMassTransformation class. The names of the temperature and salinity variables, required for density calculations, are now keyword arguments to WaterMass.__init__, rather than inferred from the watermass transformation variable dictionaries required for WaterMassTransformations.__init__. Also changed the structure such that all derived thermodynamic variables (e.g. alpha, beta, p, sa, ct) are now just added to WaterMass.ds, rather than as top-level class attributes. - Begins to address NOAA-GFDL#36 - Adresses all of NOAA-GFDL#8, except the part about expanding 2D fields to 3D. I have not yet brought swmt.py up to date with the changes herein.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Presently, the lambda options are
theta,salt, andsigma*. Sometimes the dimension name of the derived wmt (G) match this name (e.g. withsigma0) and sometimes they do not (e.g. withtheta, the coordinate name istosfor swmt).I think we should stick with easier and standard naming conventions, i.e.
temperatureandsalinity; and that the dimension name inGshould always match the specified lambda. Any disagreement? Should be an easy change.The text was updated successfully, but these errors were encountered: