Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly use python3 and pip3 executables #1486

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

timmoon10
Copy link
Collaborator

Description

Not all systems configure python to point to the Python 3 executable. For example, try installing Python in an Ubuntu Docker container and calling python:

docker run ubuntu:24.04 bash -c "apt-get update && apt-get install -y python3 && python --version"

This will fail with:

bash: line 1: python: command not found

This PR explicitly specifies python3 and pip3 so it can work on such systems. This will be especially helpful for testing.

I've also replaced some Python executables (Pylint, cpplint, pre-commit) with python -m. I don't like running containers as root, so Pip installs locally and the executables are not in my PATH.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Explicitly use python3 and pip3 instead of python and pip
  • Run Pylint, cpplint, and pre-commit with python -m

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@timmoon10 timmoon10 added the testing Improvements to tests or testing infrastructure label Feb 15, 2025
@timmoon10
Copy link
Collaborator Author

/te-ci

@timmoon10
Copy link
Collaborator Author

/te-ci core pytorch jax L0 L1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Improvements to tests or testing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant