Skip to content

Commit 373aa13

Browse files
committed
Fix argument name in windows CI
We are using `cxx` as the host compiler and `std` as the C++ version for linux tests. However, on windows we use `cxx` for the standard version, which annoys me to no end.
1 parent 8e6da27 commit 373aa13

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

.github/workflows/dispatch-build-and-test.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,5 +38,5 @@ jobs:
3838
include: ${{ fromJSON(inputs.per_cuda_compiler_matrix) }}
3939
with:
4040
test_name: ${{matrix.cpu}}/${{matrix.compiler.name}}${{matrix.compiler.version}}/C++${{matrix.std}}
41-
build_script: "./ci/windows/build_${{ inputs.project_name }}.ps1 ${{matrix.std}}"
41+
build_script: "./ci/windows/build_${{ inputs.project_name }}.ps1 -std ${{matrix.std}}"
4242
container_image: rapidsai/devcontainers:${{inputs.devcontainer_version}}-cuda${{matrix.cuda}}-${{matrix.compiler.name}}${{matrix.compiler.version}}-${{matrix.os}}

ci/windows/build_common.psm1

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
Param(
33
[Parameter(Mandatory = $true)]
4-
[Alias("cxx")]
4+
[Alias("std")]
55
[ValidateNotNullOrEmpty()]
66
[ValidateSet(11, 14, 17, 20)]
77
[int]$CXX_STANDARD = 17

ci/windows/build_cub.ps1

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
Param(
33
[Parameter(Mandatory = $true)]
4-
[Alias("cxx")]
4+
[Alias("std")]
55
[ValidateNotNullOrEmpty()]
66
[ValidateSet(11, 14, 17, 20)]
77
[int]$CXX_STANDARD = 17

ci/windows/build_libcudacxx.ps1

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
Param(
33
[Parameter(Mandatory = $true)]
4-
[Alias("cxx")]
4+
[Alias("std")]
55
[ValidateNotNullOrEmpty()]
66
[ValidateSet(11, 14, 17, 20)]
77
[int]$CXX_STANDARD = 17

ci/windows/build_thrust.ps1

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
Param(
33
[Parameter(Mandatory = $true)]
4-
[Alias("cxx")]
4+
[Alias("std")]
55
[ValidateNotNullOrEmpty()]
66
[ValidateSet(11, 14, 17, 20)]
77
[int]$CXX_STANDARD = 17

0 commit comments

Comments
 (0)