Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: thrust::shuffle gives incorrect results for size 2^32 #1073

Closed
1 task done
djns99 opened this issue Nov 9, 2023 · 1 comment · Fixed by #1074
Closed
1 task done

[BUG]: thrust::shuffle gives incorrect results for size 2^32 #1073

djns99 opened this issue Nov 9, 2023 · 1 comment · Fixed by #1074
Assignees
@elstehle
Labels
bug Something isn't working right. needs triage Issues that require the team's attention

Comments

@djns99
Copy link
Contributor

djns99 commented Nov 9, 2023

Is this a duplicate?

Type of Bug

Silent Failure

Component

Thrust

Describe the bug

When using thrust::shuffle with input arrays greater than 2^32 the philox implementation outputs duplicate values.

How to Reproduce

Run the TestFunctionIsBijection() with 2^32+1 elements, the check fails as 3 is not generated

Expected behavior

The function should generate each value exactly once

Reproduction link

No response

Operating System

No response

nvidia-smi output

No response

NVCC version

No response
@djns99 djns99 added the bug Something isn't working right. label Nov 9, 2023
@github-project-automation github-project-automation bot moved this to Todo in CCCL Nov 9, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

Hi @djns99!

Thanks for submitting this issue - the CCCL team has been notified and we'll get back to you as soon as we can!
In the mean time, feel free to add any relevant information to this issue.

@github-actions github-actions bot added the needs triage Issues that require the team's attention label Nov 9, 2023
@djns99 djns99 mentioned this issue Nov 9, 2023
Merged
2 tasks
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Nov 9, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elstehle elstehle

Labels
bug Something isn't working right. needs triage Issues that require the team's attention
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix overflow bug for >2^32 elements in thrust::shuffle djns99/cccl
2 participants
@elstehle @djns99