Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Compilation error after updating to CCCL monorepo #1170

Closed
1 task done
mfbalin opened this issue Dec 1, 2023 · 1 comment
Closed
1 task done

[BUG]: Compilation error after updating to CCCL monorepo #1170

mfbalin opened this issue Dec 1, 2023 · 1 comment
Labels
bug Something isn't working right.

Comments

@mfbalin
Copy link
Contributor

mfbalin commented Dec 1, 2023

Is this a duplicate?

Type of Bug

Compile-time Error

Component

CUB

Describe the bug

Simply including cub headers seems to cause a compilation error with CCCL branch/2.2.x. The error seems to originate from file: https://github.com/dmlc/dgl/blob/master/graphbolt/src/cuda/index_select_impl.cu

/localscratch/dgl-1/graphbolt/../third_party/cccl/cub/cub/agent/agent_three_way_partition.cuh(78): error: name followed by "::" must be a class or namespace name

/localscratch/dgl-1/graphbolt/../third_party/cccl/cub/cub/agent/agent_three_way_partition.cuh(78): error: expected an identifier

/localscratch/dgl-1/graphbolt/../third_party/cccl/cub/cub/agent/agent_three_way_partition.cuh(78): error: expected a ">"

/localscratch/dgl-1/graphbolt/../third_party/cccl/cub/cub/agent/agent_three_way_partition.cuh(78): error: expected a ";"

4 errors detected in the compilation of "/localscratch/dgl-1/graphbolt/src/cuda/index_select_impl.cu".

How to Reproduce

We have a compilation error when upgrading from the old thrust repo to the new CCCL repo 2.2.x release.
dmlc/dgl#6166

Expected behavior

There should be no compilation error due to upgrading to CCCL.

Reproduction link

No response

Operating System

No response

nvidia-smi output

No response

NVCC version

(base) root@a100cse:/localscratch/dgl-1/build# nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2022 NVIDIA Corporation
Built on Wed_Jun__8_16:49:14_PDT_2022
Cuda compilation tools, release 11.7, V11.7.99
Build cuda_11.7.r11.7/compiler.31442593_0
@mfbalin mfbalin added the bug Something isn't working right. label Dec 1, 2023
@github-project-automation github-project-automation bot moved this to Todo in CCCL Dec 1, 2023
@mfbalin mfbalin closed this as completed Dec 1, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in CCCL Dec 1, 2023
@mfbalin
Copy link
Contributor Author

mfbalin commented Dec 1, 2023

Changing #include "cub/cub.cuh" to #include <cub/cub.cuh> resolved the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right.
Projects
Archived in project
Development

No branches or pull requests

1 participant