Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Add tests for large problem sizes in cub::DeviceMergeSort and fix integer overflow for problem sizes close to numeric_limits<OffsetT>::max() #1334

Closed
4 tasks done
elstehle opened this issue Feb 2, 2024 · 0 comments · Fixed by #1419
Assignees
Labels
bug Something isn't working right. cub For all items related to CUB feature request New feature or request.

Comments

@elstehle
Copy link
Contributor

elstehle commented Feb 2, 2024

Is this a duplicate?

Area

CUB

Is your feature request related to a problem? Please describe.

After working on #1211 we should also add tests for large problem sizes (i.e., large num_items count).

Note, there are issues related to integer overflow when num_items is getting close to std::numeric_limits<OffsetT>::max(). In particular for 32-bit signed and unsigned types. So, a sub-task is to also fix potential integer overflows.

Describe the solution you'd like

  • Adding tests for 32-bit offset types, with num_items being close to std::numeric_limits<OffsetT>::max().
  • Adding tests for 64-bit offset types, with num_items being slightly above above std::numeric_limits<std::uint32_t>::max() to we are correctly computing offsets without wrapping around.
  • Fix remaining integer overflows in offset computation when num_items is close to std::numeric_limits<OffsetT>::max()

Describe alternatives you've considered

No response

Additional context

No response

@elstehle elstehle added feature request New feature or request. cub For all items related to CUB bug Something isn't working right. labels Feb 2, 2024
@github-project-automation github-project-automation bot moved this to Todo in CCCL Feb 2, 2024
@elstehle elstehle self-assigned this Feb 2, 2024
@elstehle elstehle moved this from Todo to In Progress in CCCL Feb 7, 2024
@cccl-authenticator-app cccl-authenticator-app bot moved this from In Progress to In Review in CCCL Feb 16, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right. cub For all items related to CUB feature request New feature or request.
Projects
Archived in project
1 participant