[BUG]: Return Catch2 warning suppression

[gevtushenko]

Is this a duplicate?

• I confirmed there appear to be no duplicate issues for this bug and that I agree to the Code of Conduct

Type of Bug

Compile-time Error

Component

CUB

Describe the bug

We used to suppress a warning coming from Catch2:

cccl/cub/test/catch2_test_helper.h

Lines 41 to 51 in 71267c0

	// cudafe considers some catch2 variables as unused. We have to suppress
	// these warnings until NVBug 3423950 is addressed.
	#if (CUB_HOST_COMPILER == CUB_HOST_COMPILER_MSVC) || \
	(CUB_HOST_COMPILER == CUB_HOST_COMPILER_CLANG) || \
	defined(__ICC) || defined(_NVHPC_CUDA)
	# if defined(__NVCC_DIAG_PRAGMA_SUPPORT__)
	# pragma nv_diag_suppress 177
	# else
	# pragma diag_suppress 177
	# endif
	#endif

The issue causing this warning was addressed, so we removed this suppression. There's a plan to introduce a CI config for 11.8, which will return the need for this suppression.

Along with the suppression came a policy that catch2_test_helper.h has to be included after all headers. I believe this policy should evolve to the following: 1) suppress the warning only for pre-12 CTKs, 2) do not request any particular order of CUB headers.

The reason to include catch2_test_helper.h after CUB headers was to reveal unused variables in CUB headers. Today, we can depend on CTK 12 CI to reveal unused variables.

How to Reproduce

Build with CTK 11.8

Expected behavior

Successful build

Reproduction link

No response

Operating System

No response

nvidia-smi output

No response

NVCC version

No response

[miscco]

Done in #1468