Format libcudacxx/include files without extensions #1676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
bdice
commented
Apr 30, 2024
.pre-commit-config.yaml
Outdated
There was a problem hiding this comment.
Explaining the changes here:
pre-commit looks at types (filetypes with conjunction AND), types_or (filetypes with conjunction OR), files (positive filter regex), and exclude (negative filter regex). See docs:
- https://pre-commit.com/#pre-commit-configyaml---hooks
- https://pre-commit.com/#filtering-files-with-types
The extension-to-type mapping is defined by the identify package. The source code for that is here. https://github.com/pre-commit/identify/blob/main/identify/extensions.py
I ran the following snippet on the EXTENSIONS defined in that file:
types_or = {"c", "c++", "cuda"}
for k, v in EXTENSIONS.items():
if any(t in v for t in types_or):
print(k)Then I checked the list:
c
c++
c++m
cc
ccm
cpp
cppm
cu
cuh
cxx
cxxm
h
hh
hpp
hxx
inl
ino
ixx
mm
I dropped the extensions that do not appear in the CCCL repo, and added regexes for those that do appear in this repo.
Then I added one more regex line: ^libcudacxx/include/.*/[^.]*$ which will handle the extensionless includes.
This reverts commit f542bf3.
…nclude-extensionless-files
miscco
reviewed
May 1, 2024
|
pre-commit.ci autofix |
|
/ok to test |
miscco
reviewed
May 6, 2024
We need to keep that order
miscco
approved these changes
May 6, 2024
🟨 CI Results [ Failed: 2 | Passed: 304 | Total: 306 ]
|
| # | Runner |
|---|---|
| 232 | linux-amd64-cpu16 |
| 32 | linux-amd64-gpu-v100-latest-1 |
| 24 | linux-arm64-cpu16 |
| 18 | windows-amd64-cpu16 |
👃 Inspect Changes
Modifications in project?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| CUB | |
| Thrust |
Modifications in project or dependencies?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
🟩 CI Results [ Failed: 0 | Passed: 306 | Total: 306 ]
|
| # | Runner |
|---|---|
| 232 | linux-amd64-cpu16 |
| 32 | linux-amd64-gpu-v100-latest-1 |
| 24 | linux-arm64-cpu16 |
| 18 | windows-amd64-cpu16 |
👃 Inspect Changes
Modifications in project?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| CUB | |
| Thrust |
Modifications in project or dependencies?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
|
/ok to test |
🟩 CI Results [ Failed: 0 | Passed: 306 | Total: 306 ]
|
| # | Runner |
|---|---|
| 232 | linux-amd64-cpu16 |
| 32 | linux-amd64-gpu-v100-latest-1 |
| 24 | linux-arm64-cpu16 |
| 18 | windows-amd64-cpu16 |
👃 Inspect Changes
Modifications in project?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| CUB | |
| Thrust |
Modifications in project or dependencies?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
|
Thanks a lot for helping fixing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends #1670 by adding rules to
pre-committhat invokeclang-formatover all extensionless headers in libcudacxx.Checklist