-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ceil_div #1825
Adds ceil_div #1825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for providing this utility! It's much needed, especially in a standard place like the CCCL!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have adopted the PR to account for libcu++ code style and also some correctness issues
I encountered a spec with 128 bit types, as size_t is not sufficient there
/ok to test |
return 0; | ||
} | ||
|
||
`See it on Godbolt TODO` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remark: unadressed TODO. I guess we want to fix this when ceil_div
becomes available on godbolt with the next CCCL release? But we should maybe create an issue.
/ok to test |
/ok to test |
/ok to test |
/ok to test |
🟨 CI finished in 9h 00m: Pass: 99%/361 | Total: 1d 22h | Avg: 7m 39s | Max: 39m 31s | Hits: 98%/520541
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
🏃 Runner counts (total jobs: 361)
# | Runner |
---|---|
264 | linux-amd64-cpu16 |
52 | linux-amd64-gpu-v100-latest-1 |
24 | linux-arm64-cpu16 |
21 | windows-amd64-cpu16 |
🟩 CI finished in 20h 32m: Pass: 100%/361 | Total: 1d 22h | Avg: 7m 46s | Max: 39m 31s | Hits: 98%/522243
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
🏃 Runner counts (total jobs: 361)
# | Runner |
---|---|
264 | linux-amd64-cpu16 |
52 | linux-amd64-gpu-v100-latest-1 |
24 | linux-arm64-cpu16 |
21 | windows-amd64-cpu16 |
Description
Closes #1517.