Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception type/hierarchy #2044

Closed
pciolkosz opened this issue Jul 23, 2024 · 4 comments
Closed

Add exception type/hierarchy #2044

pciolkosz opened this issue Jul 23, 2024 · 4 comments
Assignees
Labels
CUDA Next Feature intended for the Cuda Next experimental library

Comments

@pciolkosz
Copy link
Contributor

pciolkosz commented Jul 23, 2024

We should consider the exception story for the C++ Runtime and if we need some more functionality or we can just use the existing cuda_error

@github-project-automation github-project-automation bot moved this to Todo in CCCL Jul 23, 2024
@pciolkosz pciolkosz added the CUDA Next Feature intended for the Cuda Next experimental library label Jul 23, 2024
@bernhardmgruber
Copy link
Contributor

What is "the exception story"?

@pciolkosz
Copy link
Contributor Author

Exception types/hierarchy or maybe we can just use cuda_error and then there is nothing to do here.
We might also want to extend cuda_error with more functionality.

I should have added more context in the description, but I guess figuring out what are our option and what we need is the first task of this issue

@miscco
Copy link
Collaborator

miscco commented Jul 24, 2024

For now the approach is to just use cuda_error whenever we interact with a cuda API.

That might change later depending on whether we have sensible sub-types for certain categories of errors.

One point that is open is how we interface with cases where a user might expect a std::exception.

As an example a user might expect std::bad_alloc when an allocation fails. Currently we would always throw a cuda_error in that case and we might want to reconsider that

@jrhemstad
Copy link
Collaborator

Marking this as closed for now, we can always file a new issue if/when we need new exception types.

@github-project-automation github-project-automation bot moved this from Todo to Done in CCCL Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CUDA Next Feature intended for the Cuda Next experimental library
Projects
Archived in project
Development

No branches or pull requests

4 participants