Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement streaming approach for DeviceSelect and DevicePartition #2238

Closed
3 tasks done
Tracked by #1422 ...
jrhemstad opened this issue Aug 14, 2024 · 0 comments · Fixed by #2400
Closed
3 tasks done
Tracked by #1422 ...

Implement streaming approach for DeviceSelect and DevicePartition #2238

jrhemstad opened this issue Aug 14, 2024 · 0 comments · Fixed by #2400
Assignees

Comments

@jrhemstad
Copy link
Collaborator

jrhemstad commented Aug 14, 2024

PR #2205 was a prototypical implementation of a streaming implementation for DeviceSelect, which was good enough to gather some performance data but had several limitation:

  • the number of selected items actually was not written to a temporary to propagate to the i+1-th invocation

  • DevicePartition does not work out of the box, because the rejected items are written in reverse order from the end of the given output iterator. This cannot trivially be implemented using a fancy iterator approach as originally used in [DRAFT]: Experimental: Streaming DeviceSelect #2205

  • Implement [FEA]: Tabulate Output Iterator #1486 to redirect num_selected_out to either a temporary or the user-provided num_selected_out, depending on whether it's the last invocation

  • Add a kernel parameter that captures the streaming state of previous invocations

  • Adapt AgenetSelectIf to incorporate the streaming state

@github-project-automation github-project-automation bot moved this to Todo in CCCL Aug 14, 2024
@elstehle elstehle moved this from Todo to In Progress in CCCL Aug 28, 2024
@elstehle elstehle changed the title Implement streaming approach to DevicePartition as drafted in https://github.com/NVIDIA/cccl/pull/2205 Implement streaming approach for DeviceSelect and DevicePartition Aug 28, 2024
@cccl-authenticator-app cccl-authenticator-app bot moved this from In Progress to In Review in CCCL Sep 20, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants