Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Update CPM to use FetchContent_MakeAvailable #2350

Closed
1 task done
Tracked by #2366
miscco opened this issue Sep 3, 2024 · 1 comment · Fixed by #2495
Closed
1 task done
Tracked by #2366

[FEA]: Update CPM to use FetchContent_MakeAvailable #2350

miscco opened this issue Sep 3, 2024 · 1 comment · Fixed by #2495
Assignees
Labels
feature request New feature or request.

Comments

@miscco
Copy link
Collaborator

miscco commented Sep 3, 2024

Is this a duplicate?

Area

Infrastructure

Is your feature request related to a problem? Please describe.

In our CI we are getting warnings of the kind:

CMake Warning (dev) at /usr/share/cmake-3.30/Modules/FetchContent.cmake:1953 (message):
Calling FetchContent_Populate(CCCL) is deprecated, call
FetchContent_MakeAvailable(CCCL) instead. Policy CMP0169 can be set to OLD
to allow FetchContent_Populate(CCCL) to be called directly for now, but the
ability to call it with declared details will be removed completely in a
future version.

We should update our CPM scripts accordingly

Describe the solution you'd like

Use the new approach

Describe alternatives you've considered

No response

Additional context

No response

@miscco miscco added the feature request New feature or request. label Sep 3, 2024
@alliepiper alliepiper added this to CCCL Oct 2, 2024
@github-project-automation github-project-automation bot moved this to Todo in CCCL Oct 2, 2024
@alliepiper alliepiper moved this from Todo to In Progress in CCCL Oct 2, 2024
@alliepiper
Copy link
Collaborator

cpm-cmake/CPM.cmake#588

This should be fixed in 0.40.1 per the above issue. #2495 updates our CPM version to 0.40.2 and should fix it.

@alliepiper alliepiper linked a pull request Oct 3, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in CCCL Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants