Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Incorrect check for cudax flag #2423

Closed
1 task done
osayamenja opened this issue Sep 18, 2024 · 4 comments
Closed
1 task done

[BUG]: Incorrect check for cudax flag #2423

osayamenja opened this issue Sep 18, 2024 · 4 comments
Assignees
Labels
bug Something isn't working right.

Comments

@osayamenja
Copy link

osayamenja commented Sep 18, 2024

Is this a duplicate?

Type of Bug

Something else

Component

CCCL

Describe the bug

In cccl-config.cmake, the check for CCCL_ENABLE_UNSTABLE always returns false.

Instead, the check should be

if(DEFINED ENV{CCCL_ENABLE_UNSTABLE} AND "$ENV{CCCL_ENABLE_UNSTABLE}")
     # ....
endif()

How to Reproduce

Set CCCL_ENABLE_UNSTABLE=ON or any truth value and try to import CCCL::cudax

Expected behavior

Doing the above should include the cudax target.

Reproduction link

Operating System

N/A

nvidia-smi output

N/A

NVCC version

N/A

@osayamenja osayamenja added the bug Something isn't working right. label Sep 18, 2024
@github-project-automation github-project-automation bot moved this to Todo in CCCL Sep 18, 2024
@jrhemstad
Copy link
Collaborator

@alliepiper any chance you already took care of this as part of the cleanup you're doing?

@alliepiper
Copy link
Collaborator

Nope, but I'll add it to the list.

@alliepiper
Copy link
Collaborator

This is working as intended. That is not an environment variable, but rather a cmake variable that should be defined before find_package(CCCL).

set(CCCL_ENABLE_UNSTABLE ON)
find_package(CCCL)

@github-project-automation github-project-automation bot moved this from Todo to Done in CCCL Sep 25, 2024
@osayamenja
Copy link
Author

This is working as intended. That is not an environment variable, but rather a cmake variable that should be defined before find_package(CCCL).

set(CCCL_ENABLE_UNSTABLE ON)
find_package(CCCL)

Yes, verified that this works! I misunderstood the README, thinking it was an env variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right.
Projects
Archived in project
Development

No branches or pull requests

3 participants