Integrate cudastf into CudaX. #2526
Conversation
- Global instead of local - Use `cuda/experimental` - s/.h$/.cuh$/g
These currently require different compile options from the rest of CudaX.
These functions are used in both logical_data.cuh and acquire_release.cuh. Move them to where they'll be visible to both.
|
We currently have duplicated some std libraries in
We probably need to move away from these local copy, and possibly use the mdspan copy available for libcudacxx ? |
|
@caugonnet I think that's a good idea. I don't know if we have all of those bits ready yet, but we at least have mdspan and stuff. I've added this as a line item to #2533 to track it. |
|
/ok to test |
|
/ok to test |
|
/ok to test |
I added this common_type_t bit, but it breaks when compiling unittest headers. Removing it for now so we can find a more suitable fix.
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
| template <typename U> \ | ||
| auto operator op(const U& rhs)&& \ | ||
| { \ | ||
| const bool r = value op rhs; \ |
There was a problem hiding this comment.
This breaks compilation due to comparing different types now, we should revert that change and get it work
|
Closing in favor of #2572. |
No description provided.