-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
promote the cudax __async/config.cuh
to be the config for all of cudax
#2638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a good idea to have a central configuration header for cudax, but I was wondering if it would make sense to add the annotation macros as the CCCL level, so all of them consistently start with CCCL(...)? That can also happen later if needed
🟩 CI finished in 1h 33m: Pass: 100%/400 | Total: 1d 23h | Avg: 7m 09s | Max: 46m 17s | Hits: 79%/25701
|
Project | |
---|---|
+/- | CCCL Infrastructure |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
pycuda | |
CCCL C Parallel Library |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
+/- | CCCL C Parallel Library |
🏃 Runner counts (total jobs: 400)
# | Runner |
---|---|
326 | linux-amd64-cpu16 |
31 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
i considered that. i would like to be able to just use maybe @miscco has ideas about how to fix those two |
My 2 cts are that i doubt forceinline is really of any benefit and would rather drop that completely |
removing forceinline everywhere is beyond the scope of this pr. but maybe you meant something different? |
I meant to not include it in the macro so that there is no clash with the other inline |
🟩 CI finished in 2h 44m: Pass: 100%/400 | Total: 7d 07h | Avg: 26m 16s | Max: 1h 24m | Hits: 35%/25793
|
Project | |
---|---|
+/- | CCCL Infrastructure |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 400)
# | Runner |
---|---|
326 | linux-amd64-cpu16 |
31 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
/ok to test |
🟨 CI finished in 1h 05m: Pass: 99%/400 | Total: 2d 10h | Avg: 8m 50s | Max: 46m 42s | Hits: 75%/25793
|
Project | |
---|---|
+/- | CCCL Infrastructure |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 400)
# | Runner |
---|---|
326 | linux-amd64-cpu16 |
31 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
🟩 CI finished in 1h 41m: Pass: 100%/400 | Total: 2d 10h | Avg: 8m 49s | Max: 46m 42s | Hits: 75%/25793
|
Project | |
---|---|
+/- | CCCL Infrastructure |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 400)
# | Runner |
---|---|
326 | linux-amd64-cpu16 |
31 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
Description
cudax could benefit from a central
config.cuh
header where we can put configuration settings and portability macros that need to be shared across all of cudax. this PR promotes theconfig.cuh
that was in the__async/
directory to__detail/config.cuh
. it also defines some helpful attribute macros since the_CCCL
ones are currently lacking.Checklist