-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement C++26 std::span
's constructor from std::initializer_list
#2923
Merged
miscco
merged 9 commits into
NVIDIA:main
from
davebayer:impl_cxx_26_std_span_initializer_list
Nov 22, 2024
Merged
implement C++26 std::span
's constructor from std::initializer_list
#2923
miscco
merged 9 commits into
NVIDIA:main
from
davebayer:impl_cxx_26_std_span_initializer_list
Nov 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
requested changes
Nov 21, 2024
libcudacxx/test/libcudacxx/std/containers/views/views.span/span.cons/initializer_list.pass.cpp
Outdated
Show resolved
Hide resolved
libcudacxx/test/libcudacxx/std/containers/views/views.span/span.cons/initializer_list.pass.cpp
Outdated
Show resolved
Hide resolved
libcudacxx/test/libcudacxx/std/containers/views/views.span/span.cons/initializer_list.pass.cpp
Outdated
Show resolved
Hide resolved
libcudacxx/test/libcudacxx/std/containers/views/views.span/span.cons/initializer_list.pass.cpp
Outdated
Show resolved
Hide resolved
libcudacxx/test/libcudacxx/std/containers/views/views.span/span.cons/initializer_list.pass.cpp
Outdated
Show resolved
Hide resolved
libcudacxx/test/libcudacxx/std/containers/views/views.span/span.cons/initializer_list.pass.cpp
Outdated
Show resolved
Hide resolved
pre-commit.ci autofix |
/ok to test |
miscco
approved these changes
Nov 22, 2024
/ok to test |
scratch my last comment, the constructor with dynamic extent is non explicit |
/ok to test |
miscco
approved these changes
Nov 22, 2024
🟩 CI finished in 1h 51m: Pass: 100%/396 | Total: 7d 00h | Avg: 25m 28s | Max: 1h 19m | Hits: 48%/22042
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 396)
# | Runner |
---|---|
327 | linux-amd64-cpu16 |
28 | linux-arm64-cpu16 |
26 | linux-amd64-gpu-v100-latest-1 |
15 | windows-amd64-cpu16 |
davebayer
added a commit
to davebayer/cccl
that referenced
this pull request
Nov 22, 2024
NVIDIA#2923) Co-authored-by: Michael Schellenberger Costa <[email protected]>
trxcllnt
pushed a commit
to trxcllnt/cccl
that referenced
this pull request
Nov 23, 2024
NVIDIA#2923) Co-authored-by: Michael Schellenberger Costa <[email protected]>
davebayer
added a commit
to davebayer/cccl
that referenced
this pull request
Nov 25, 2024
NVIDIA#2923) Co-authored-by: Michael Schellenberger Costa <[email protected]>
davebayer
added a commit
to davebayer/cccl
that referenced
this pull request
Dec 2, 2024
NVIDIA#2923) Co-authored-by: Michael Schellenberger Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of P2447R6 "
std::span
over an initializer list" from C++26 which is made available back to C++14.As the paper says, this is a breaking change. For more info see chapter
4 - Breaking changes
. Because of the backport, there could be potential problems for user's coming fromstd::span
tocuda::std::span
before C++26.